Migrate terminal shell integration to AsyncIterableProducer#307810
Open
Ultrarunner5 wants to merge 1 commit intomicrosoft:mainfrom
Open
Migrate terminal shell integration to AsyncIterableProducer#307810Ultrarunner5 wants to merge 1 commit intomicrosoft:mainfrom
Ultrarunner5 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…terableProducer Addresses part of microsoft#256854. The terminal shell execution data stream was using AsyncIterableObject which retains all emitted values in an internal _results array, causing a potential memory leak for long-running terminal sessions with large output. Migrated ShellExecutionDataStream to use AsyncIterableProducer which does not store values, and replaced the toPromise()-based flush with DeferredPromise tracking for completion signaling. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
@Ultrarunner5 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Contributor
|
@Ultrarunner5 please don't ping random people |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AsyncIterableObject→AsyncIterableProducerinextHostTerminalShellIntegration.ts, addressing part of Review AsyncIterableObject usage: potential memory leaks and migration to AsyncIterableProducer #256854ShellExecutionDataStreamwas retaining all emitted terminal output inAsyncIterableObject._results, causing a potential memory leak for long-running sessionstoPromise()-based flush (which re-iterated the stream) withDeferredPromisecompletion tracking — simpler and avoids the need for multi-iteration supportChanges
AsyncIterableObject.EMPTY→AsyncIterableProducer.EMPTYfor the empty data stream caseShellExecutionDataStream.createIterable()now usesAsyncIterableProducer+DeferredPromisefor completion signalingflush()awaits the deferred promises instead of re-iterating viatoPromise()Test plan
extHostTerminalShellIntegration.test.tstests passcc @Tyriar
🤖 Generated with Claude Code